Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point to upstream http-client. #3950

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Point to upstream http-client. #3950

wants to merge 2 commits into from

Conversation

elland
Copy link
Contributor

@elland elland commented Mar 13, 2024

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Mar 13, 2024
MangoIV
MangoIV reviewed Mar 14, 2024
View reviewed changes
services/galley/src/Galley/External/LegalHoldService/Internal.hs
Comment on lines -84 to +83
(mgr, verifyFingerprints) <- view (extEnv . extGetManager)
makeVerifiedRequestWithManager mgr verifyFingerprints fpr url reqBuilder
mkMgr <- view extGetManager
mgr <- liftIO $ mkMgr [fpr]
makeVerifiedRequestWithManager mgr url reqBuilder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changes behaviour afaict, the manager is being reinitialized with manF every time because manF :: [FingerPrint] -> IO Manager and not IO ([FingerPrint] -> IO Manager)

This has the same culprit as I already identified a few weeks ago, namely that due to the manager not being reused, the connection is not reused either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MangoIV MangoIV MangoIV left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elland @MangoIV @zebot