Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wait for isSelfATeamMember when setting up Analytics - (WPB-8978) #3258

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Jul 31, 2024

TaskWPB-8978 [Android] Countly analytics ID and user properties


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

With our last implementation of Analytics and setting user profile, we needed to set if user is a team member

Causes (Optional)

The way we were getting the value it was getting the default value (false) and not properly waiting for its updated value.

Solutions

Use waitUntilLive() from syncManager to wait until we have the proper value for this property

Dependencies (Optional)

Needs releases with:

Testing

How to Test

  • Open App
  • Login
  • Wait until sync is done
  • Verify your analytics ID against our analytics dashboard and that the user custom properties is set with the correct value

@alexandreferris alexandreferris self-assigned this Jul 31, 2024
@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, borichellow, vitorhugods, ohassine and Garzas and removed request for a team July 31, 2024 09:12
Copy link

sonarcloud bot commented Jul 31, 2024

@alexandreferris alexandreferris added this pull request to the merge queue Jul 31, 2024
Copy link
Contributor

Built wire-android-staging-compat-pr-3258.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3258.apk is available for download

Merged via the queue into develop with commit bd07441 Jul 31, 2024
13 of 14 checks passed
@alexandreferris alexandreferris deleted the chore/analytics_wait_for_team_value branch July 31, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants