Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: externalize all wire links to support custom builds (WPB-9811) 🍒 #3160

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 4, 2024

BugWPB-9811 [Android] - C1, C2, C3 related Links are outdated- add new links as below - on Custom builds

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

For custom builds, we need to support external URLs not necessary into the wire website.

Causes (Optional)

Not supported / Out of initial scope

Solutions

  • Move URLs to urls.xml file, so external builds can have their own if necessary.
  • Fixes some URLs that were localized, this is not necessary since wire portal handles this according to the browser locale.

Note

Most of the changes are removing entries from strings resources, this can be ignored to have a better review.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added the size/S label Jul 4, 2024
@yamilmedina yamilmedina changed the title chore: externalize all wire links to support custom builds (WPB-9811) 🍒 chore: externalize all wire links to support custom builds 🍒 Jul 4, 2024
@yamilmedina yamilmedina changed the title chore: externalize all wire links to support custom builds 🍒 chore: externalize all wire links to support custom builds (WPB-9811) 🍒 Jul 4, 2024
@yamilmedina yamilmedina enabled auto-merge (squash) July 5, 2024 15:11
Copy link
Contributor Author

github-actions bot commented Jul 5, 2024

Test Results

12 tests   12 ✅  0s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit b422540.

@pull-request-size pull-request-size bot added size/L and removed size/S labels Jul 5, 2024
Copy link

sonarcloud bot commented Jul 5, 2024

@yamilmedina yamilmedina merged commit 02f4203 into release/candidate Jul 5, 2024
12 of 13 checks passed
@yamilmedina yamilmedina deleted the chore/links-for-custombuilds-cherry-pick branch July 5, 2024 16:04
Copy link
Contributor Author

github-actions bot commented Jul 5, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants