Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move Analytics to user-level (WPB-9584) #3142

Merged
merged 11 commits into from
Jul 5, 2024
Merged

chore: Move Analytics to user-level (WPB-9584) #3142

merged 11 commits into from
Jul 5, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Jun 28, 2024 •
edited by github-actions bot
Loading

TaskWPB-9584 [Android] Move Analytics Settings to User-Level

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Anonymous analytics was being initialized from a global-level (meaning there was no need of a valid session)

Solutions

Move anonymous analytics initialization to user-level (user must be logged in and have a valid session)

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

WIP

@alexandreferris alexandreferris self-assigned this Jun 28, 2024
@alexandreferris alexandreferris added WIP Work In Progress DO NOT MERGE labels Jun 28, 2024
@alexandreferris
chore: remove unused import
14cdc57 
Signed-off-by: alexandreferris <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-staging-release-pr-3142.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

Built wire-android-dev-debug-pr-3142.apk is available for download

@alexandreferris alexandreferris removed WIP Work In Progress DO NOT MERGE labels Jul 3, 2024
@alexandreferris alexandreferris requested review from a team, MohamadJaara, vitorhugods, mchenani, ohassine, saleniuk, yamilmedina and Garzas and removed request for a team July 3, 2024 11:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Built wire-android-staging-compat-pr-3142.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Built wire-android-dev-debug-pr-3142.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Built wire-android-staging-compat-pr-3142.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Built wire-android-dev-debug-pr-3142.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Built wire-android-staging-compat-pr-3142.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Built wire-android-dev-debug-pr-3142.apk is available for download

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Built wire-android-staging-compat-pr-3142.apk is available for download

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Built wire-android-dev-debug-pr-3142.apk is available for download

alexandreferris
alexandreferris commented Jul 5, 2024
View reviewed changes
Copy link
Contributor Author

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Force merging this PR as the only failing action is from smoke tests and its due to an internal Jenkins error.

@alexandreferris alexandreferris merged commit c8fb882 into develop Jul 5, 2024
10 of 11 checks passed
@alexandreferris alexandreferris deleted the chore/analytics_move_to_user_level branch July 5, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@Garzas Garzas Garzas approved these changes

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

@saleniuk saleniuk Awaiting requested review from saleniuk saleniuk was automatically assigned from wireapp/android

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

Assignees

@alexandreferris alexandreferris

Labels
size/XS
Projects
None yet
Milestone
No milestone
4 participants
@alexandreferris @MohamadJaara @Garzas @yamilmedina