Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove any mention to maven local repo [WPB-2799] #3104

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

MohamadJaara
Copy link
Member

@MohamadJaara MohamadJaara commented Jun 17, 2024

StoryWPB-2799 Submit wire-android-reloaded to F-Droid


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

android sample app and in few other places maven local repo is mentioned

Solutions

those are not used anymore so delete em

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Built wire-android-staging-release-pr-3104.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3104.apk is available for download

@MohamadJaara MohamadJaara changed the title chore: remove any mention to maven local repo chore: remove any mention to maven local repo [WPB-2799] Jun 19, 2024
Copy link

sonarcloud bot commented Jun 24, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Jun 24, 2024
Merged via the queue into develop with commit 094c1aa Jun 24, 2024
9 checks passed
@yamilmedina yamilmedina deleted the chore/remove-maven-local-repo branch June 24, 2024 09:03
Copy link
Contributor

Built wire-android-staging-release-pr-3104.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3104.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants