fix: update last read message on conversation opening [WPB-7208] #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garzas
requested review from
yamilmedina,
alexandreferris,
MohamadJaara and
saleniuk
alexandreferris
approved these changes
Mar 26, 2024
saleniuk
reviewed
Mar 26, 2024
| @@ -839,6 +839,8 @@ fun MessageList( | |||
| selectedMessageId: String? | |||
| ) { | |||
| val prevItemCount = remember { mutableStateOf(lazyPagingMessages.itemCount) } | |||
| val readLastMessageAtStartTriggered = remember { mutableStateOf(false) } | |||
There was a problem hiding this comment.
This state is not being set to true anywhere 🤔
There was a problem hiding this comment.
Wow, moving function I forgot about that...
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit bdf4ea6. ♻️ This comment has been updated with latest results. |
…reapp/wire-android-reloaded into fix/update-last-read-message-on-start
saleniuk
approved these changes
Mar 26, 2024
4 tasks
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3759 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When user opens conversation screen messages are not being marked as read until user will scroll.
Solutions
Additional LauncherEffect to be triggered at start to mark latest message as read