fix: Remove autologin in Keycloak in E2EI [WPB-7061] #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
yamilmedina,
alexandreferris,
MohamadJaara,
vitorhugods,
mchenani and
saleniuk
Test Results809 tests 809 ✅ 11m 33s ⏱️ Results for commit 639d06a. |
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3507 succeeded. The build produced the following APK's: |
alexandreferris
approved these changes
Mar 8, 2024
app/src/main/kotlin/com/wire/android/ui/e2eiEnrollment/GetE2EICertificateViewModel.kt
Show resolved
Hide resolved
MohamadJaara
approved these changes
Mar 11, 2024
|
APKs built during tests are available here. Scroll down to Artifacts! |
|
Build 3512 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
Keyclok and WebView that opens it cache users creds. So if user logs in with the wrong creds in Keyclok and tries to enroll E2EI certificate, he gets an error and no chance to change it and get a certificate (until cache is cleared).
Solutions
add
AuthorizationRequest.Prompt.LOGINparameter intoAuthorizationRequest, it makes Keycloak force user to enter password (even when the creds are cached) OR sing out and sign in with another creds.Attachments (Optional)