Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add structured logs to location and fix permission handling (WPB-6358) #2734

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Feb 23, 2024

TaskWPB-6358 [Android] Location feature logs observability


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • Add logs while getting location, so we can monitor for example; usages by gms, non-gms, location not enabled, etc.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Feb 23, 2024
@yamilmedina yamilmedina requested review from a team, typfel, borichellow, mchenani, Garzas, e-lisa, alexandreferris and MohamadJaara and removed request for a team and e-lisa February 23, 2024 11:02
@AndroidBob
Copy link
Collaborator

Build 3294 failed.

Copy link
Contributor

Test Results

803 tests   803 ✅  9m 19s ⏱️
108 suites    0 💤
108 files      0 ❌

Results for commit 3fe2e2e.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@yamilmedina yamilmedina enabled auto-merge (squash) February 23, 2024 12:38
@yamilmedina yamilmedina merged commit c9dd591 into release/candidate Feb 23, 2024
10 of 11 checks passed
@yamilmedina yamilmedina deleted the chore/location-logs branch February 23, 2024 12:56
@AndroidBob
Copy link
Collaborator

Build 3303 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants