Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: applock toggle state when enforced and responding to changes [WPB-5751] #2564

Merged

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Jan 2, 2024

BugWPB-5751 [Android] App lock toggle is green in settings, when enforced by team


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Currently, the app lock toggle is visible with ON value but just disabled when the app lock is enforced by the team admin. According to the designs in that case the toggle should be hidden and only "ON" text should be visible.
Also when the user is on that screen and the team admin changes the setting, it doesn't get updated automatically but only after closing and opening it again.

Solutions

Change the appearance of the app lock row so that if it's enforced by the team admin then the toggle is not shown but just a text is visible.
Use the updated use case to observe the editable app lock value changes instead of getting just a single value.

Dependencies (Optional)

Needs releases with:

Testing

How to Test

Open settings screen and change the app lock team settings on team admin panel.

Attachments (Optional)

applock_toggle_changes.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Test Results

702 tests   702 ✅  8m 37s ⏱️
 99 suites    0 💤
 99 files      0 ❌

Results for commit 3499804.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk saleniuk requested review from a team, yamilmedina, borichellow, MohamadJaara, Garzas and ohassine and removed request for a team January 3, 2024 09:02
@AndroidBob
Copy link
Collaborator

Build 2438 failed.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2452 succeeded.

The build produced the following APK's:

Copy link
Contributor

github-actions bot commented Jan 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2454 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit 3f5defc into release/candidate Jan 4, 2024
15 checks passed
@saleniuk saleniuk deleted the fix/applock-toggle-and-observing-updates branch January 4, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants