Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use enroll mls use case (WPB-5756) #2514

Merged
merged 11 commits into from
Dec 13, 2023

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Dec 11, 2023

Sub-taskWPB-5756 Connect E2EI Renewal Dialog to E2EI Enrollment Usecase

What's new in this PR?

Issues

In Device settings AND E2EIRequired dialog: when user clicks on "Get Certificate" button nothing happens

Causes (Optional)

The getting certificate it self wasn't implemented yet.

Solutions

  • use GetE2EICertificateUseCase in these cases.
  • implement error handling for getting the certificate.

Required kalium PR

@AndroidBob
Copy link
Collaborator

Build 2228 failed.

Copy link
Contributor

@borichellow looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
ab83fea4e235cc3c6936d5c7788dd90035014593 454088c4918db1d0c4f66cb2d937a0eabbe2c67a

Is this intentional?

Copy link
Contributor

github-actions bot commented Dec 11, 2023

Test Results

727 tests  +1   727 ✔️ +1   10m 18s ⏱️ +8s
100 suites ±0       0 💤 ±0 
100 files   ±0       0 ±0 

Results for commit 4642947. ± Comparison against base commit c5b8aa5.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2229 failed.

Copy link
Contributor

@borichellow looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
ab83fea4e235cc3c6936d5c7788dd90035014593 454088c4918db1d0c4f66cb2d937a0eabbe2c67a

Is this intentional?

@AndroidBob
Copy link
Collaborator

Build 2234 failed.

@AndroidBob
Copy link
Collaborator

Build 2238 failed.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #2514 (4642947) into develop (c5b8aa5) will decrease coverage by 0.12%.
The diff coverage is 17.80%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2514      +/-   ##
=============================================
- Coverage      41.19%   41.07%   -0.12%     
- Complexity      1112     1114       +2     
=============================================
  Files            355      355              
  Lines          12926    12988      +62     
  Branches        1690     1695       +5     
=============================================
+ Hits            5325     5335      +10     
- Misses          7096     7149      +53     
+ Partials         505      504       -1     
Files Coverage Δ
...id/ui/settings/devices/model/DeviceDetailsState.kt 100.00% <100.00%> (ø)
.../android/feature/e2ei/GetE2EICertificateUseCase.kt 0.00% <0.00%> (ø)
...otlin/com/wire/android/ui/home/FeatureFlagState.kt 92.59% <50.00%> (-7.41%) ⬇️
...rc/main/kotlin/com/wire/android/ui/WireActivity.kt 0.00% <0.00%> (ø)
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 63.04% <23.07%> (-7.90%) ⬇️
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 57.92% <7.69%> (-8.12%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b8aa5...4642947. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2245 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 2258 succeeded.

The build produced the following APK's:

@borichellow borichellow added this pull request to the merge queue Dec 13, 2023
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2023
@AndroidBob
Copy link
Collaborator

Build 2271 succeeded.

The build produced the following APK's:

@borichellow borichellow added this pull request to the merge queue Dec 13, 2023
Merged via the queue into develop with commit 2050462 Dec 13, 2023
14 checks passed
@borichellow borichellow deleted the feat/use_enroll_mls_use_case branch December 13, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants