Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parse ClientId as an URI #74

Merged
merged 2 commits into from
Jan 10, 2024
Merged

feat: parse ClientId as an URI #74

merged 2 commits into from
Jan 10, 2024

Conversation

beltram
Copy link

@beltram beltram commented Jan 3, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@beltram beltram self-assigned this Jan 3, 2024
@beltram beltram requested a review from OtaK January 3, 2024 16:12
@github-actions github-actions bot added the size/s label Jan 3, 2024
@beltram beltram removed the request for review from OtaK January 3, 2024 18:17
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Merging #74 (1ac09f7) into feat/rfc9420 (7496165) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/rfc9420      #74      +/-   ##
================================================
- Coverage         80.56%   80.56%   -0.01%     
================================================
  Files               172      172              
  Lines             16961    16960       -1     
================================================
- Hits              13665    13663       -2     
- Misses             3296     3297       +1     

@beltram beltram merged commit 19c3d7a into feat/rfc9420 Jan 10, 2024
47 of 48 checks passed
@beltram beltram deleted the feat/clientid-uri branch January 10, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants