Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly serialize/deserialize HashReference directly to string #6

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

augustocdias
Copy link


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Implements serialization/deserialization into the HashReference directly into string, so that, maps that has it as keys can be successfully (de)serialized to json.

Issues

The MlsGroup struct cannot be serialized when there is commits pending to be merged.

Solutions

Serialize the HashReference directly into a hex string.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@augustocdias augustocdias marked this pull request as draft July 7, 2022 10:59
@augustocdias augustocdias marked this pull request as ready for review July 7, 2022 11:05
@augustocdias augustocdias requested a review from OtaK July 7, 2022 12:01
@OtaK OtaK force-pushed the bug/fix-hash-serialization branch from 425141b to 58ea2fd Compare July 7, 2022 15:56
@augustocdias augustocdias merged commit 1318edb into feat/async Jul 8, 2022
@augustocdias augustocdias deleted the bug/fix-hash-serialization branch July 8, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants