Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/x509 rustcrypto #34

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Feat/x509 rustcrypto #34

merged 2 commits into from
Mar 22, 2023

Conversation

beltram
Copy link

@beltram beltram commented Mar 22, 2023

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Stop relying on x509-parser because of its ring dependency

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@beltram beltram requested a review from OtaK March 22, 2023 14:25
@beltram beltram merged commit 3f8e12b into feat/async Mar 22, 2023
@beltram beltram deleted the feat/x509-rustcrypto branch March 22, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OtaK OtaK OtaK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beltram @OtaK