Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: review external commit [CL-90] #16

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

beltram
Copy link

@beltram beltram commented Sep 22, 2022


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • join_by_external_commit returns a valid PublicGroupState which becomes valid when the external commit gets merged
  • Group configuration is carried in PublicGroupState so that it becomes freestanding and one has not to fetch a configuration from its custom Delivery Service

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…comes valid when the external commit gets merged
@beltram beltram requested a review from OtaK September 26, 2022 07:32
@beltram beltram marked this pull request as ready for review September 26, 2022 07:33
@beltram beltram changed the title feat: review external commit feat!: review external commit [CL-90] Sep 26, 2022
@beltram beltram merged commit d5c8c4f into feat/async Sep 26, 2022
@beltram beltram deleted the feat/ext-commit branch September 26, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants