Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: all commit operations return a potential GroupInfo #13

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

beltram
Copy link

@beltram beltram commented Aug 8, 2022


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

As exporting a GroupInfo (currently PublicGroupState) requires commit to be merged, we have all commit methods return a hypothetical GroupInfo which only becomes valid once the commit is merged


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@beltram beltram requested a review from OtaK August 8, 2022 15:53
@beltram beltram merged commit 328abc7 into feat/async Aug 9, 2022
@beltram beltram deleted the feat/group-info branch August 9, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants