Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump kalium coroutines version to 1.6.0 [AR-1204] #256

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

gongracr
Copy link
Contributor

@gongracr gongracr commented Mar 9, 2022


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After adding coil library to this PR, some issue with conflicting versions of the android coroutines library appeared. It seems that the compiler will complain about the versions diff between them.

Solutions

Bump the Kalium coroutines library version to 1.6.0 to be consistent with the one in wire-android-reloaded

Needs to release before:

wireapp/wire-android#427

  • GitHub link to other pull request

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods
Copy link
Contributor

We should solve this on Android Reloaded side, and replace the 1.6.0 with 1.6.0-native-mt there if possible.

native-mt is the only way to enable multi-threading in coroutines right now for Multiplatform projects.
That is, on iOS everything would fall apart if we use 1.6.0.

In any case, this would be a temporary solution. From Coroutines 1.7.0 there won't be any difference between them.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Unit Test Results

  85 files    85 suites   5s ⏱️
180 tests 179 ✔️ 1 💤 0
355 runs  353 ✔️ 2 💤 0

Results for commit 2d68d32.

Copy link
Contributor

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it breaks iOS we revert and find an alternative

@gongracr
Copy link
Contributor Author

gongracr commented Mar 9, 2022

I tried also using the 1.6.0-native-mt version for the Android Reloaded project, but it didn't work either. Therefore I would still propose to go ahead with the current PR, and bump to 1.7.0 it as soon as it is released if nothing else breaks on iOS

@gongracr gongracr merged commit e08c2c6 into develop Mar 9, 2022
@gongracr gongracr deleted the fix/conflict_coroutines_version branch March 9, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants