Add support for Javascript Sentry Support #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeTowers
reviewed
Dec 13, 2022
LukeTowers
reviewed
Dec 13, 2022
LukeTowers
reviewed
Dec 13, 2022
LukeTowers
reviewed
Dec 13, 2022
Plugin.php
Outdated
| @@ -46,6 +47,10 @@ public function boot() | |||
| app('sentry')->captureException($exception); | |||
| } | |||
| }); | |||
|
|
|||
| if ($jsDsn = env('SENTRY_JAVASCRIPT_DSN')) { | |||
There was a problem hiding this comment.
Use the config instead here, sentry.dsn_js, set in winter.sentry.packages.sentry/sentry-laravel.config.dsn_js. That way it can be dynamically configured on a per request basis, for instance if someone wanted to inject a different DSN in the backend vs the frontend contexts.
There was a problem hiding this comment.
I did try this before, but ran into this issue:
There was a problem hiding this comment.
@jaxwilko that's because you're using js_dsn, it's defined as dsn_js
There was a problem hiding this comment.
Yeah but it doesn't matter what it's called, if you add something that is missing from the predefined list of options, it throws the exception, see:
LukeTowers
reviewed
Dec 13, 2022
LukeTowers
reviewed
Dec 13, 2022
LukeTowers
reviewed
Dec 13, 2022
Co-authored-by: Luke Towers <[email protected]>
LukeTowers
reviewed
Feb 27, 2023
LukeTowers
reviewed
Feb 27, 2023
LukeTowers
approved these changes
Feb 27, 2023
… into wip/js-sentry
LukeTowers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a javascript specific sentry monitor.
Add:
SENTRY_JAVASCRIPT_DSN="..."to your .env and the plugin will dynamically inject the sdk and it's configs into backend and frontend pages.