Support Laravel 9 / PHP 8.1

[LukeTowers]

Winter is well on its way to supporting Laravel 9! Thank you for your interest in providing testing for this work, please read the following information on how to get started testing it and report any issues that you encounter!

See https://github.com/wintercms/meta/blob/master/l9-upgrade-notes.md for testing instructions and the upgrade guide.

Must Have

These issues are crucial for a smooth upgrade process and must be completed before 1.2 can go "stable":

Internals:

• Support Laravel 9 LTS storm#46
• Can't get twig filter in macros #578 (comment)
• Revert: Default QueryBuilder methods are defined in the Builder class now preventing the user of $builder->macro() to override them in userspace, see [9.x] Query builder interface laravel/framework#37956 (comment) for details.
• Code analysis for Laravel 9 branch storm#64
• Method Winter\Storm\Translation\Translator::set does not exist #480
• octobercms/library@29ad917 (evaluate)
• Can't pass null to non-nullable arguments storm#81
• Flysystem disks visibility #503

v1.1.9 Final changes:

• Add unit test for overriden to() method storm#88

Third Party / Dependencies:

• barryvdh/laravel-debugbar doesn't support Twig v3.x yet, Winter.DebugBar should replace usage of Twig pieces to add support for v3 or a PR should be submitted upstream.

Post "stable" release:

The following features were added in Laravel 7-9 and require extra work to "winterize" them for easier consumption / usage in Winter projects. These do not delay "stable" release but should be dealt with soon after:

New Features:

• Maintenance mode functionality changed in Laravel 8, see [8.x] Improved Maintenance Mode laravel/framework#33560. Explore combining backend maintenance mode setting with the framework maintenance mode, or better document the differences between them and what they're each best used for.
• Core support for CORS: https://laravel.com/docs/7.x/upgrade#cors-support
• Review Queue monitoring functionality
• Review RateLimiter functionality
• Review Prunable/MassPrunable model traits, especially as it relates to identifying models in the application
• Review Model Broadcasting
• Review ImmutableDates
• Finish implementing create:model
• Finish implementing create:migration
• Review Laravel commands to identify ones that can be marked as replaced in Winter for aliasing and any that need to be "Winterized".
• Review the difference between Laravel registered default commands and Winter ones and decide which Laravel ones to add / modify for use in Winter.
• Symfony 5.4 added support for autocompletion in console commands, add support to all core commands and document it. Note: Currently waiting on documentation from Symfony
• Newer Laravel versions don't require manual registration of console commands, investigate how we can implement that for modules and plugins and get rid of our registration code for console commands: https://laravel.com/docs/9.x/artisan#registering-commands
• Opis/Closure also used in the ExtendableTrait functionality to support serializing classes with dynamic methods (Double check that the usage of the encryption key for serializable closures is being correctly applied)
• Restore full Laravel Mailer behavior #45
• Add SVG utility storm#61
• [WIP] Revise class loader #481

Maintenance:

• Investigate removing helpers that are now present by default in PHP 8.0
• Multiple changes to improve support for relationship pivot data storm#65
• Laravel 8.12 introduced support for encryptable casts ([8.x] Add encrypted string Eloquent cast laravel/framework#34937 & laravel/framework@1cf5513), review and decide how the Encryptable trait should work with this. Technically compatible as of changes in upgrade to laravel 8 storm#26
• Review the Laravel 6 upgrade (Move to Laravel 6 octobercms/october#4381 & Rebase October CMS on Laravel 6 octobercms/october#4893) to ensure that nothing was overlooked in the previous upgrade.
• Review calls to $app->getNamespace() that assume a single application namespace (Usually \App) instead of a collection of modules & plugins that all form the namespace. This is typically used for autoloading files and cleaning up output to remove extra unnecessary paths but those tasks should be handled completely differently in Winter CMS.
• Laravel v7 introduced changes to getOriginal() in the Model class (HasAttributes trait). The Halcyon model base class does not implement this trait but instead implements similar methods. The Halcyon model base class should be refactored to make use of the HasAttributes trait from Eloquent as much as possible and only provide overrides where necessary.
• Review YamlProcessor implementation and decide if it needs to be cut down even more.
• Review Winter\Storm\Foundation\Bootstrap\LoadConfiguration -> Illuminate\Foundation\Bootstrap\LoadConfiguration for conformity with Laravel base class (ties into support for app.env configuration variable instead of just APP_ENV.
• Review the helpers that we override from Laravel to make them match up as much as possible (https://github.com/laravel/framework/blob/8b2cdb1dc88af4777ae17dd7279936707f40409e/src/Illuminate/Foundation/helpers.php#L820-L837 vs https://github.com/wintercms/storm/blob/develop/src/Support/helpers.php#L28-L41 (for that one we can possibly go back to the Laravel one but extend e() to turn the parameter into a string first.
• Revise class loader storm#72
• Updated jquery to 3.6.0, jquery migrate to 3.3.2 #521
• Check DebugBar dependency for merging of Implemented support for Twig 3 barryvdh/laravel-debugbar#1318

Documentation:

• Document new ArraySource trait
• Document new tests structure
• Update 1.2 mail docs to reflect the changes to the configuration files and the introduction of the Driver plugins.
• Event dispatcher now supports closure event handlers and queued closure handlers, review and document

API Changes:

• Revise Cache system (see 9314a44)

Completed Work:

The following items have all been completed as a part of this Laravel 9 upgrade. Great job to everyone who contributed!

New Features:

• Add support for # as a path symbol that represents the themes directory.
• LazyLoad console commands ([9.x] Add support for lazy loading commands laravel/framework#34873 & [9.x] Lazy load Laravel commands laravel/framework#34925) (Related: Updated artisan service provider to be compatible with laravel storm#60)
• Investigate Anonymous Migrations (https://laravel-news.com/laravel-anonymous-migrations) and alias artisan migrate to winter:up (fixed in wintercms/storm@b16bb17)
• [Enhancement] Add ArrayFile & EnvFile Parsing, replace ConfigWriter internal logic storm#40
• [Enhancement] Refactor winter:env, winter:install to use new EnvFile & ArrayFile parsers #404

Maintenance / Cleanup:

• Reorganize tests out of the project tests folder and into module / plugin specific tests folders.
• Reorganize Console commands into the appropriate modules (Remove scaffold commands from Storm storm#70, Move scaffold commands #471, Move scaffolding commands into System module #270)
• Fix skipped tests
• Review changes to artisan serve (included by the framework now instead of required to existing in the project root)
• Refactor Twig registration and usage #455
• [WIP] 1.2 Test Split - Modules own tests #581

Compatibility Layer:

• Review including a polyfill for the removed {% spaceless %} tag in Twig v3.0 (Retain spaceless tag in Twig #456)
• Revise YAML processor system to only engage the processors if the original parsing fails (see wintercms/wn-translate-plugin@a219d7e for an example of currently valid YAML that fails if it gets preprocessed).
• Illuminate\Support\Arr was moved to Illuminate\Collections\Arr (Illuminate Support Arr class not found. laravel/framework#34292 (comment)) (namespace remained the same, file location changed)
• TransportManager renamed to MailManager, check to make sure functionality / public API are unaffected
• ErrorHandler changes to typehint / reference "Throwable" instead of "Exception", check to make sure public API / extensions of this behavior continue to work as expected.
• Update MailSettings for new Laravel mail config structure. #522
• Fix closure listener with parameters as reference storm#69
• Error with decompiled assets in 1.2 #562
• Call to undefined method addVisible #567

Dependencies:

• upgrade to laravel 8 storm#26
• Switching to Assetic as an external dependency removed the change in FilesystemCache where File::chmod($path) is called, investigate if that actually causes issues for us and we need to implement it in an override or if we're fine.
• Review upgrade to Flysystem v3 (v2 support was added in Winter 1.2 WIP branch, v3 needs to be assessed & tested)
• Revert composer dependencies to stable versions
• Bump minimum version of Laravel to 9.1.0 (see laravel/framework@63ca843)
• YAML upgraded from 3 to 5.1 ([WIP v1.2] Add full compatibility with Symfony\Yaml 4.4 storm#21)
• Remove the embedded implementation of Assetic v1 and utilize Assetic v2 instead.

[LukeTowers]

@bennothommo can you resolve the conflict with the ViewMaker test?

Stale