Model: make string attribute value auto-trimming optional #97
Conversation
because not all attributes are made equal.
|
@lex0r can you add the test case from the original PR? https://github.com/octobercms/library/pull/503/files#diff-270f442232291e973d322f9166dda6fb544ad2325f6db11581f7d553171213a8 Also I'm curious to know your use case and what problems auto trimming was causing for you, are you able to share some details? |
* develop: Apply fix from 1.0 Add test case for trimStringAttributes flag Make string attribute value auto-trimming optional (#97) # Conflicts: # src/Database/Attach/File.php
* develop: Apply fix from 1.0 Add test case for trimStringAttributes flag Make string attribute value auto-trimming optional (#97) Added additional test case for UrlGenerator class (#90) Improve port validation when building URLs Avoid issues coming from double encoded URLs remove non-existent argument to Ini::parse() method (#82) Fix docblock typehint (#71) Code quality and windows test fix Improve Halcyon SectionParser logic
Great addition here!! As I remember, my use case was forum messages including markdown: if you start a message with a code block using tab instead of three backticks, the tabs was trimmed and the code block just didn't work... |
@LukeTowers I had to save a file to a remote location directly without any pre-processing and then save a record linking to it in the database. The file name can contain trailing spaces and that is acceptable, however when trying to save such a name in the database you would get the name trimmed. Later on we used the name to construct a link to the file and potential spaces were not included in that link which made it impossible to locate the file in the remote storage which has the file saved with the space. |
|
Interesting, thanks for sharing your use case @lex0r! |
because not all attributes are made equal.