Add Array Source trait #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original constructor required a Container container, which while correct, cannot be resolved in tests. By default, Maker is brought in with the Winter application, and there's no real mechanism to override this, so changing this signature should be fine.
This should allow facades and other expected functionality to work, basically making the tests work with a real Laravel app.
If we ever get around to namespacing our test cases, this will help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remake of #73.
This PR introduces the ability to create an "array source" model which provides arbitrary records via an array. These models will act, for all intents and purposes, as Eloquent models, but do not require a database.
The implementation of this feature is inspired by the Sushi library by Caleb Porzio but modified to work in Winter's architecture.
This PR also introduces a change to the testing suite, to cater for the facades used in this trait, and now creates a dummy application when running tests, which resolves a long-standing issue where facades in the test cases did not work.