Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added php8.0 features to Resizer #77

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Added php8.0 features to Resizer #77

wants to merge 3 commits into from

Conversation

jaxwilko
Copy link
Member

A simple PR that adds some php8.0 features and enforces return types.

Something of note, all the widths & heights should probably be ints but in reality they work off floats and changing them to int breaks the tests.

This PR lays groundwork for future improvements.

@jaxwilko jaxwilko marked this pull request as draft March 18, 2022 16:14
@jaxwilko
Copy link
Member Author

There maybe a bug when trying to resize in crop mode where the calculated values (float) for width & height are passed to crop() and implicitly cast to int resulting in a potential issue.

Need to add more tests for better coverage of the $resizer->setOptions(['mode' => ...]) feature.

@github-actions
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@LukeTowers LukeTowers added this to the 1.2.1 milestone Jul 15, 2022
Base automatically changed from wip/1.2 to develop July 15, 2022 06:59
@bennothommo bennothommo modified the milestones: 1.2.1, v1.2.2 Sep 12, 2022
@LukeTowers LukeTowers modified the milestones: v1.2.2, v1.2.3 Apr 20, 2023
@LukeTowers LukeTowers modified the milestones: v1.2.3, v1.2.4 Jul 7, 2023
@LukeTowers LukeTowers removed this from the v1.2.4 milestone Dec 27, 2023
@LukeTowers
Copy link
Member

@jaxwilko can you remerge develop into this branch and then let me know what's left on it?

@LukeTowers LukeTowers added this to the 1.3.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants