Improved the unique validation rule test cases #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennothommo
reviewed
Apr 30, 2021
bennothommo
added
Status: Response Needed
and removed
Status: Review Needed
Status: Testing Needed
labels
LukeTowers
commented
Apr 30, 2021
|
@bennothommo is this good to go? |
|
@LukeTowers yep, I believe so. :) |
LukeTowers
added a commit
that referenced
this pull request
Aug 20, 2021
* develop: Cleanup user impersonation inline docs and ensure the impersonation is working on the current request as well as future requests. Fix bug where user impersonation would sometimes fail Code quality Reorganize helper functions and add new ones. Improvements to URL generation (#45) Add support for trusted proxies (#42) Add issue notice to README Add shields to README Tweak GitHub Actions Retrieve and store headers if Http::toFile() method is used. (#44) Improved aliasing and plugin replacement (#38) Reduce the calls to PathResolver::resolve for speed (#34) Add pagination for queries using havings (#39) Add missing import to FilesystemAdapter (#33) Improved the unique validation rule test cases (#29) Remove old build files Support multiple where clauses in Unique validation rules (#28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves some inconsistencies noticed by @Flynsarmy.
@bennothommo @Flynsarmy if you guys could do a sanity check on this for me please that would be great.