-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to laravel 8 #26
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
e59b50a
Upgraded laravel to ^8.0
tschallacka 4fa71da
Updated composer.json to ignore eclipse files
tschallacka d570980
Updated requirement to php 7.4
tschallacka ad9f2ea
Removed Storm QueryBuilder as typehint, as this invalidates the metho…
tschallacka ae9c706
Removed typehint for setKeySForSaveQuery as that invalidates the pare…
tschallacka bb35db7
Fixed import path, should have been Query instead of Eloquent
tschallacka 850b42c
Fixed import path, should have been Query instead of Eloquent
tschallacka 8352939
Added default value null to to make the method signature compatible …
tschallacka c146ccf
Changed Exception to Throwable to make the methods compatible with pa…
tschallacka 639e6fe
Transport manager was changed in Mail Manager in laravel 7.
tschallacka b951da4
Added a todo note
tschallacka d5ec7d9
Changed the use of the encrypter variable as it is a static variable …
tschallacka db15860
added a name to the Mailer constructor
tschallacka c0bd766
Removed variable
tschallacka bc8ac3e
Resolving merge conficts
tschallacka 18db743
Resolving merge conficts
tschallacka 2434782
Merge branch 'wip/1.2' into 1.2
tschallacka 4999eda
Set php version to 7.3 as laravel 8 only requires that.
tschallacka a10f1a8
Fixed code style issues
tschallacka 1161361
Merge branch '1.2' of https://github.com/tschallacka/storm into 1.2
tschallacka 6286f15
Removed backports of compileUpsert in SQL grammars
tschallacka fe6b883
Removed phpunit result cache and added it to the gitignore
tschallacka 2be2479
Fixed unit tests, as the compare compiled queries were missing a semi…
tschallacka 8f288e4
Removed php 7.2 runner from github workflow
tschallacka 421d088
Added a unit test for version.yaml interpretation
tschallacka 9650316
bring back the editorconfig. removed by accident
tschallacka e81f03b
Update .editorconfig
LukeTowers d646c0b
Removed Yaml version test as per https://github.com/wintercms/storm/p…
tschallacka f7d1a37
Removing 7.3 support as per https://github.com/wintercms/storm/pull/2…
tschallacka 5a75f0a
Reverted to original
tschallacka 0d38c6b
Renamed to to to conflict with the static variable in Eloquent\Model
tschallacka 488952d
Removed Throwable and Exception imports, added root namespace in fron…
tschallacka 43f521e
Added unit test for dispatcher on changed events that are accepted on…
tschallacka 943d516
Merge branch '1.2' of https://github.com/tschallacka/storm into 1.2
tschallacka 2e7c58c
Update tests/fixtures/events/EventTest.php
LukeTowers 99be292
Update composer.json
LukeTowers 3c3a437
Fixed code sniffer errors. Also learned how to run code sniffer.
6e7f2ff
Moved non public api methods to use throwable in the method name to r…
tschallacka 652c7b8
Targetting dev-master for laravel 9
tschallacka 1cda0eb
Added unit tests for priorities in event handlers
tschallacka 2813f8d
Upgraded emitter to accept Events like Dispatcher does
tschallacka 6da4242
Removed constants per descission https://github.com/wintercms/storm/p…
tschallacka e0c8e33
Update src/Extension/ExtendableTrait.php
LukeTowers 0e88018
Code quality fix
tschallacka 5397549
Code quality fix
tschallacka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Changed Exception to Throwable to make the methods compatible with pa…
…rent class
- Loading branch information
commit c146ccf5831346ecfc796f2250cceefa79b0df90
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to get rid of the exception import at the top of the file, and we'll need to update the remaining references to \Exception (especially in the event docblocks) in this class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception and Throwable imports are gone now, slashes are passed around like a grandma handing out candy on halloween.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, we can still import the Throwable so we don't have to have slashes everywhere in the file, just wanted the exception import removed because as far as I could tell the exception class wasn't being used anywhere in the class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used here. A lone usage. Do you want me to return the imports so the slashes can go?
storm/src/Foundation/Exception/Handler.php
Line 181 in e81f03b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything in the base class that would suggest we can't just make that use throwable as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes to the class, everything is now throwable oriented.