Update Symfony/Yaml to v4, add support for YAML processing #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
@bennothommo On second glance, shouldn't the VersionYamlProcessor be located in the system module? Makes it harder to test the processor logic here, but perhaps we can add a basic processor as a test fixture here and then the full version yaml processor test in the winter repo instead. Also the VersionManager needs to set the processor in order for this to take effect anyways. |
|
@LukeTowers sounds good - will sort that out, although I won't put a test in for Storm as we can assume Yaml is adequately tested by Symfony, and I can't think of another processor we need right now. |
LukeTowers
pushed a commit
to wintercms/winter
that referenced
this pull request
Mar 28, 2021
Fixes #13 Follows on from wintercms/storm#16 Moves the version.yaml processing into the System module and updates all version file parsing to use this new processor.
LukeTowers
pushed a commit
to wintercms/wn-system-module
that referenced
this pull request
Mar 28, 2021
Fixes #13 Follows on from wintercms/storm#16 Moves the version.yaml processing into the System module and updates all version file parsing to use this new processor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wintercms/winter#13
This PR upgrades
symfony/yamlto version 4.4 to match the rest of the Symfony components in Storm. To support oldversion.yamlfile types, this also adds processor support for the YAML parser, and adds a pre-processor that will fix up most issues in oldversion.yamlfiles so that they correctly parse.I've tried to cover most bases where the new Symfony YAML parser might trip up, but if anyone can think of other cases, please let me know so I can add them to the test case.