Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max-depth restriction from getAvailablePaths #148

Merged
merged 1 commit into from
May 29, 2023

Conversation

jaxwilko
Copy link
Member

This PR removes the limit put in place in #135 in order to fix wintercms/wn-blocks-plugin#6.

From memory, I believe not restricting the path cache caused issues when using a combination of child themes and blocks which lead to a theme datasource structure of:

AutoDatasource: 
    - AutoDatasource:
        - FileDatasource - child
        - FileDatasource - parent
    - BlocksDatasourcce

image

However after some testing I was not able to reproduce the error, therefore this PR reverts the change.

@LukeTowers LukeTowers added this to the v1.2.2 milestone May 29, 2023
@LukeTowers LukeTowers merged commit e228543 into develop May 29, 2023
6 checks passed
@LukeTowers LukeTowers deleted the fix/limited-cache-paths branch May 29, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants