Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid empty properties like id='' which is invalid #142

Closed
wants to merge 2 commits into from
Closed

Avoid empty properties like id='' which is invalid #142

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c69365
Avoid empty properties like id='' which is invalid
AIC-BV Feb 23, 2023
0c18f8a
change !is_null/!empty to !isset
AIC-BV Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
Avoid empty properties like id='' which is invalid 
Credits to @mjauvin
  • Loading branch information
@AIC-BV
AIC-BV committed Feb 23, 2023
commit 4c69365896a10a2b417e74dadbfef1ac4e49bc8b
2 changes: 1 addition & 1 deletion src/Html/FormBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ public function input(string $type, ?string $name = null, ?string $value = null,
$merge = compact('type', 'value', 'id');

$options = array_filter(array_merge($options, $merge), function ($item) {
return !is_null($item);
return !empty($item);
AIC-BV marked this conversation as resolved.
Show resolved Hide resolved
});
}

Expand Down