Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withoutChildren scope to NestedTree #105

Closed
wants to merge 1 commit into from

Conversation

RomainMazB
Copy link
Contributor

Currently building a Winter.User blogs plugin, based on Winter.Blog.
I needed to list all the available parent categories for the current one, but excluding the current category's children to avoid circular references.

I thought it would be good to add this scope to the core.

@LukeTowers
Copy link
Member

@RomainMazB can you add a unit test for this?

@RomainMazB
Copy link
Contributor Author

All the actual tests are included in wintercms/winter, is there where you want me to add it?

As a side note, it could be more clear to pull back almost all of this wintercms/winter test folder inside winter/storm as most of the tests are more related to storm than winter IMO

@bennothommo
Copy link
Member

@RomainMazB

As a side note, it could be more clear to pull back almost all of this wintercms/winter test folder inside winter/storm as most of the tests are more related to storm than winter IMO

I agree with this. It's something on my list to do, but the list is loooooooong, so won't be any time soon.

@mjauvin mjauvin added this to the 1.2.2 milestone Sep 12, 2022
@github-actions
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@LukeTowers
Copy link
Member

@RomainMazB the tests have been reorganized in the Winter core now, are you able to add a test case for this? Ideally at some point we should probably be able to run database tests on this library directly but for now a PR to the wintercms/winter with the test case for this addition and perhaps an addition to the docs and we should be able to merge this.

@bennothommo
Copy link
Member

Just to note, we can run database tests in Storm. There's a couple of them in there now - https://github.com/wintercms/storm/tree/develop/tests/Database/Traits. They just need to extend the DbTestCase base test class.

LukeTowers added a commit to wintercms/docs that referenced this pull request Nov 29, 2022
@github-actions
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@LukeTowers
Copy link
Member

@RomainMazB are you still interested in getting this merged?

@github-actions
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants