Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wildcard listener do not support priority #57

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Wildcard listener do not support priority #57

merged 1 commit into from
Mar 1, 2022

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Feb 22, 2022

No description provided.

@mjauvin
Copy link
Member Author

mjauvin commented Mar 1, 2022

Can this be merged?

@LukeTowers
Copy link
Member

Do you have a link to the source where I can read into it? Need to verify it for my own personal understanding of the codebase

@mjauvin
Copy link
Member Author

mjauvin commented Mar 1, 2022 •
edited
Loading

Here:
https://github.com/wintercms/storm/blob/develop/src/Events/Dispatcher.php#L33-L44

Specifically this line:
https://github.com/wintercms/storm/blob/develop/src/Events/Dispatcher.php#L37

Also here when fetching the listeners:
https://github.com/wintercms/storm/blob/develop/src/Events/Dispatcher.php#L152-L155

Wildcard Listeners are merged AFTER the ones sorted by priority.

Laravel has no listener priority (setupWildcardListen)

@LukeTowers LukeTowers merged commit 4654d58 into wintercms:wip/1.2 Mar 1, 2022
@mjauvin mjauvin deleted the wildcard-listener-no-priority branch March 1, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Completed Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mjauvin @LukeTowers