Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #191

Closed
Closed

Conversation

nmiyazaki-chapleau
Copy link
Contributor

Here's a resubmit of #190 but to the develop branch.

@nmiyazaki-chapleau nmiyazaki-chapleau mentioned this pull request Jun 7, 2024
@mjauvin
Copy link
Member

mjauvin commented Jun 7, 2024

This is not right, services/helpers.md has unwanted changes.

@nmiyazaki-chapleau
Copy link
Contributor Author

services/helpers.md was changed in commit 4a0bd8f on the branch 1.2 but wasn't committed to develop. I can still remove it from this PR if you prefer?

@mjauvin
Copy link
Member

mjauvin commented Jun 7, 2024

Nah, I think I remember @bennothommo merges everything back to develop if needed, so I'll close this pr. Sorry for the trouble.

@mjauvin mjauvin closed this Jun 7, 2024
@nmiyazaki-chapleau
Copy link
Contributor Author

Gotcha, no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants