-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix links in markup docs #151
Conversation
Should be merged also in 1.2 branch for changes to be reflected on Docs website. |
Changes are reflected in the docs website when we clear the cache; we need to add that as a step to the webhook processing. |
@LukeTowers please clear the cache |
Done @WebVPF |
@LukeTowers It turns out that the pull request was made in the wrong branch. |
@WebVPF thanks, I merged it into the correct branch but the site is waiting on a PR to allow for both branches to play nicely together. At the moment I'm just having trouble with the UI for switching between branches of the documentation, perhaps you could have a look and let me know your thoughts? I don't like how duplicated it looks and feel like there's a better way to handle selecting from a different version of the docs, but don't have time to mock up an example at the moment. Do you think you could take a stab at it or provide some input? |
Ideally the release flow will be that the main docs on the website will be the dev branch (so the master branch like on Laravel) and then if people want to switch to a different version they can; with the docs release cycle following the same as the main code itself (when a new version is released dev is merged into the current main branch for the main winter repo as well as now the docs repo). |
Note that I'd like to be able to provide each of the main branches (currently 1.1, 1.2, and dev, but very soon 1.3, 1.4, etc) |
@LukeTowers |
@bennothommo does that work for you? |
@LukeTowers @WebVPF I suppose that will work, but will need to find a new home for the theme switcher (dark/light). To be honest, I also want to remove the landing page altogether - it's an unnecessary extra click to get to where you want. It's only in the Nabu theme as an example. |
@WebVPF I went this way, implementing your ideas: |
@LukeTowers Will the fixes from this Pull Request ever work in the documentation on the site? |
@WebVPF yes, we have pending changes to the main website docs, just waiting for us to finish testing / merge it in. Check back in with me in a week if I haven't dealt with it by then. |
@LukeTowers will this PR be included in the documentation? |
@bennothommo I can't remember at the moment, was there anything special we needed to do to trigger the docs to update on the main website? I know we still have to merge the multi-branch support PR but this should have been deployed automatically when I merged the 1.2.4 docs pr into the 1.2 branch AFAIK. |
@LukeTowers I think we have them hooked up to webhooks, but there is a URL you can go to direct to refresh the docs. I can send to you if needed :) |
@bennothommo please do :) |
https://wintercms.com/docs/v1.2/markup