Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create install command #4

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
+2,929 −40
Draft

Create install command #4

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3e1f14e
WIP install command
bennothommo Sep 10, 2020
c41f957
Fix int check
bennothommo Sep 11, 2020
d5a3054
Further WIP
bennothommo Sep 11, 2020
d0fa2fe
Merge branch 'master' into wip/install-command
bennothommo Oct 3, 2020
6d6f6dd
Further WIP
bennothommo Oct 3, 2020
e9e678b
Merge branch 'master' into wip/install-command
bennothommo Mar 9, 2021
1a6d377
October -> Winter
bennothommo Mar 9, 2021
8843f88
Merge branch 'master' into wip/install-command
bennothommo Mar 9, 2021
5ed7132
Fix PHPCS warning
bennothommo Mar 9, 2021
f550858
Further WIP
bennothommo Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix PHPCS warning
  • Loading branch information
@bennothommo
bennothommo committed Mar 9, 2021
commit 5ed7132502de2eca7644765fc3875d20bf37e8c3
4 changes: 2 additions & 2 deletions src/Filesystem/PathResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ public static function resolve($path)
$drive = array_shift($resolvedSegments) ?: null;
continue;
} elseif (is_file($currentPath) && $i < (count($pathSegments) - 1)) {
// If we've hit a file and we're trying to relatively traverse the path further, we need to fail at this
// point.
// If we've hit a file and we're trying to relatively traverse the path further, we need to fail
// at this point.
return false;
}
} catch (Throwable $e) {
Expand Down