Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ByteDance Logo #23

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Add ByteDance Logo #23

merged 2 commits into from
Jun 17, 2022

Conversation

XadillaX
Copy link
Contributor

No description provided.

@XadillaX XadillaX mentioned this pull request Jun 15, 2022
Closed
@jasnell
Copy link
Contributor

jasnell commented Jun 15, 2022

@XadillaX ... this is great to see. With the PR, we also need some statement making it clear that we have permission from ByteDance to use the logo/trademark.

@XadillaX
Copy link
Contributor Author

@XadillaX ... this is great to see. With the PR, we also need some statement making it clear that we have permission from ByteDance to use the logo/trademark.

Sure, I've already passed our company's progress. Should I send that file to somewhere?

@jasnell
Copy link
Contributor

jasnell commented Jun 15, 2022

Just copy / screenshot the relevant bits of the permission to this PR and that should work just fine.

@XadillaX
Copy link
Contributor Author

XadillaX commented Jun 15, 2022 •
edited
Loading

I'm not sure that the content of permission is public or not. Should I paste it in this PR? Or find a more private place to send?

mcollina
mcollina approved these changes Jun 15, 2022
View reviewed changes
Copy link

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lucacasonato
Copy link
Member

I'm not sure that the content of permission is public or not. Should I paste it in this PR? Or find a more private place to send?

Feel free to DM it to @jasnell or me on Matrix if it is not public.

@XadillaX
Copy link
Contributor Author

I'm not sure that the content of permission is public or not. Should I paste it in this PR? Or find a more private place to send?

Feel free to DM it to @jasnell or me on Matrix if it is not public.

Done. I've DM you the file on Matrix. Thanks.

lucacasonato
lucacasonato approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @XadillaX.

@lucacasonato lucacasonato merged commit 1fddb65 into wintercg:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@XadillaX @jasnell @lucacasonato @mcollina