Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accessibility): Use article/div instead of ul/li #18

Merged
merged 1 commit into from
May 11, 2022
Merged

fix(accessibility): Use article/div instead of ul/li #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(accessibility): Use article/div instead of ul/li 
Signed-off-by: 迷渡 <[email protected]>
  • Loading branch information
@justjavac @lucacasonato
justjavac authored and lucacasonato committed May 11, 2022
commit 58675de7a2a1477f24633c17a16bd7d8091498f8
16 changes: 8 additions & 8 deletions main.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ function Work() {
The WinterCG is currently working on various efforts to improve web
platform APIs across runtimes:
</p>
<ul class="mt-8 space-y-6">
<div class="mt-8 space-y-6">
{work.map((item) => (
<li>
<article>
<h2 class="text-xl font-medium">{item.name}</h2>
<p class="text-lg">{item.description}</p>
<p class="flex gap-4">
Expand All @@ -64,9 +64,9 @@ function Work() {
</a>
)}
</p>
</li>
</article>
))}
</ul>
</div>
<Footer />
</Layout>
);
Expand Down Expand Up @@ -377,7 +377,7 @@ const PARTNER_LOGOS = [
function Logos() {
return (
<div>
<ul class="mt-16 flex justify-evenly">
<div class="mt-16 flex justify-evenly">
{RUNTIME_LOGOS.map(({ src, href, name }) => (
<a href={href}>
<img
Expand All @@ -388,11 +388,11 @@ function Logos() {
/>
</a>
))}
</ul>
</div>
<p class="mt-16 text-center">
The work of the WinterCG is supported by:
</p>
<ul class="mt-8 flex gap-4 flex-wrap justify-evenly sm:justify-evenly items-center h-16">
<div class="mt-8 flex gap-4 flex-wrap justify-evenly sm:justify-evenly items-center h-16">
{PARTNER_LOGOS.map(({ src, href, name, restrict }) => (
<a href={href}>
<img
Expand All @@ -405,7 +405,7 @@ function Logos() {
/>
</a>
))}
</ul>
</div>
</div>
);
}
Expand Down