Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more details and example to the binding section #6

Merged
merged 1 commit into from
Sep 7, 2023
Merged

add more details and example to the binding section #6

merged 1 commit into from
Sep 7, 2023

Conversation

Ethan-Arrowood
Copy link
Contributor

closes #2

Adds some details discussed on the issue thread.

dom96
dom96 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though might be worth mentioning that the configuration doesn't necessarily have to live in the JS code (in fact, that's the whole point of these bindings).

@jasnell jasnell merged commit e6de68b into main Sep 7, 2023
@jasnell jasnell deleted the expand-binding-object-section branch September 7, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand "Binding Object" section
3 participants
@Ethan-Arrowood @dom96 @jasnell