Add ready promise and close reason #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `socket.ready` promise that is resolved when the socket connection has been established. Adds an optional `reason` argument to `socket.close()` that is to be forwarded on to the underlying `ReadableStream` and `WritableStream` when they are canceled/aborted.
Ethan-Arrowood
approved these changes
Sep 8, 2023
dom96
reviewed
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
socket.readypromise that is resolved when the socket connection has been established.Adds an optional
reasonargument tosocket.close()that is to be forwarded on to the underlyingReadableStreamandWritableStreamwhen they are canceled/aborted.