Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove self from minimum #30

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Remove self from minimum #30

merged 1 commit into from
Dec 1, 2022

Conversation

jasnell
Copy link
Contributor

@jasnell jasnell commented Nov 3, 2022

globalThis.self really doesn't meet the criteria for inclusion in the minimum.

@jasnell
Remove self from minimum
364fdab 
`globalThis.self` really doesn't meet the criteria for inclusion in the minimum.
@zloirock
Copy link

zloirock commented Nov 3, 2022

Right on time -) 2 months without feedback and already added to core-js because of this.

Ethan-Arrowood
Ethan-Arrowood approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we omit similar properties like window, I agree this doesn't need to be in the minimum API.

@jasnell jasnell merged commit 7893fb1 into main Dec 1, 2022
@jasnell jasnell deleted the jasnell-remove-globalThis-self branch December 1, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jasnell @zloirock @Ethan-Arrowood