Hardy bearing text printing #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed |
|
(@winsomniak ) |
|
Was this one not initHP? We have some ambiguity here, but if I remember correctly the properties are as follows: hp - maximum hp |
|
If it is so... Then let me make sure everything is okay... |
|
We should add that to the wiki once you confirm. Save citizens of the future some headaches. Haha |
winsomniak
approved these changes
Feb 19, 2018
There was a problem hiding this comment.
Looks good, I'll test with the other changes. Ideally we run some automated and manual tests before approving pull requests but there's quite a build up here so I'm trying to hit it all at once. Beta release would probably be a good idea too, but I'll cram these smaller changes in with the new heroes.
Cheers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#56
Could you please check the HP thing here too... Seems to be broken. Sorry.