Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assassin's Bow + Windsweep has incorrect interaction #65

Closed
YukariTea opened this issue Jan 16, 2018 · 0 comments
Closed

Assassin's Bow + Windsweep has incorrect interaction #65

YukariTea opened this issue Jan 16, 2018 · 0 comments
Assignees
Labels

Comments

@YukariTea
Copy link
Collaborator

What should be happening:
The contradictory effects cancel out (“no follow-up occurs” from Windsweep and the guaranteed follow-up attack attack from Assassin's Bow), resulting in the normal speed check deciding ability to perform follow-up attacks.

The remaining conditions and effects are still active. No counterattack from the dagger foe “if unit’s Spd - foe’s Spd ≥ 1” (from Windsweep). The dagger foe cannot perform a follow-up attack regardless of their speed (from Assassin's Bow).

What is happening:
Assassin's Bow's guaranteed follow-up effect is overriding Windsweep's no follow-up effect instead of canceling out. Follow-up attacks are incorrectly occurring regardless of speed.

Remaining conditions and effects appear to be implemented correctly.

Link to reproduce:

@YukariTea YukariTea added the bug label Jan 16, 2018
Lorenzooone added a commit that referenced this issue Jan 16, 2018
Fixes #65
(Which I didn't even know was a thing)
@Lorenzooone Lorenzooone self-assigned this Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants