Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(token): Be consistent on take_until("") #490

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 28, 2024

We aren't consistent on empty buffers between simd and not.

Fixes #489

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 41.82%. Comparing base (c3e3e4d) to head (9d50921).

Files Patch % Lines
src/stream/mod.rs 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
- Coverage   41.83%   41.82%   -0.01%     
==========================================
  Files          18       18              
  Lines        3043     3046       +3     
==========================================
+ Hits         1273     1274       +1     
- Misses       1770     1772       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8083211839

Details

  • -7 of 12 (41.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 41.825%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/stream/mod.rs 5 12 41.67%
Totals Coverage Status
Change from base Build 8073857515: -0.009%
Covered Lines: 1274
Relevant Lines: 3046

💛 - Coveralls

@epage epage merged commit c8fb68e into winnow-rs:main Feb 28, 2024
14 of 17 checks passed
@epage epage deleted the sub branch February 28, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Winnow and nom produce differing outcomes when running identical code when use take_until
2 participants