Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for -v in the wing-cli #6763

Closed
boyney123 opened this issue Jun 24, 2024 · 4 comments · Fixed by #6835
Closed

Add support for -v in the wing-cli #6763

boyney123 opened this issue Jun 24, 2024 · 4 comments · Fixed by #6835
Assignees
Labels
⌨️ cli CLI ✨ enhancement New feature or request good first issue Good for newcomers

Comments

@boyney123
Copy link
Contributor

boyney123 commented Jun 24, 2024

Use Case

Very minor issue, but might be nice to support -v on the wing-cli to get the version of wing.

Wing currently supports wing -V, be nice to support wing -v too.

Proposed Solution

Desired experience would be to support both -V and -v to get the installed version of wing-cli.

Implementation Notes

Similar to how we have it implemented for -V, just extend for -v

Component

CLI

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
  • If this issue is labeled needs-discussion, it means the spec has not been finalized yet. Please reach out on the #dev channel in the Wing Discord.
@boyney123 boyney123 added ✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl labels Jun 24, 2024
@Chriscbr Chriscbr added the ⌨️ cli CLI label Jun 24, 2024
@staycoolcall911
Copy link
Contributor

Should be pretty easy to add to the CLI.

Implementation details: for the CLI we're using Commander JS, which provides the -V (uppercase) for version out of the box. I'd start by looking how to also support lowercase -v in Commander and add the solution in https://github.com/winglang/wing/blob/main/apps/wing/src/cli.ts
I think this is the line that implicitly adds the -V option:

program.name("wing").version(PACKAGE_VERSION);

@staycoolcall911 staycoolcall911 added good first issue Good for newcomers and removed needs-discussion Further discussion is needed prior to impl labels Jun 30, 2024
@boyney123
Copy link
Contributor Author

OK cool, I'm happy to pick this up

@boyney123 boyney123 self-assigned this Jul 3, 2024
@staycoolcall911
Copy link
Contributor

You got it

@mergify mergify bot closed this as completed in #6835 Jul 3, 2024
mergify bot pushed a commit that referenced this issue Jul 3, 2024
fixes #6763

Wing CLI currently supports `-V` and `--version`.

This adds the ability to `-v` to get the current version.


## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.76.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⌨️ cli CLI ✨ enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants