Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Workflow #79

Closed
3 tasks done
dvandyk opened this issue Aug 18, 2021 · 2 comments
Closed
3 tasks done

Github Workflow #79

dvandyk opened this issue Aug 18, 2021 · 2 comments
Assignees
@dvandyk

Comments

@dvandyk
Copy link
Collaborator

dvandyk commented Aug 18, 2021 •
edited
Loading

  • use pypa/gh-action-pypi-publish instead of manual upload via twine
  • use PyPI access token
  • check that the tag correspond to the version number recorded in the source code (suggest by @klieret)
@dvandyk dvandyk self-assigned this Aug 18, 2021
@klieret
Copy link
Member

klieret commented Aug 18, 2021

Also fix #80

dvandyk added a commit that referenced this issue Aug 18, 2021
@dvandyk
[github] Verify that release and source code versions match
06add80 
Github: resolves #79
dvandyk added a commit that referenced this issue Aug 18, 2021
@dvandyk
[github] Verify that release and source code versions match
4c9febf 
Github: resolves #79
dvandyk added a commit that referenced this issue Aug 18, 2021
@dvandyk
[github] Verify that release and source code versions match
269a55e 
Github: resolves #79
dvandyk added a commit that referenced this issue Aug 18, 2021
@dvandyk
[github] Verify that release and source code versions match
f40e000 
Github: resolves #79
@klieret
Copy link
Member

klieret commented Aug 18, 2021 •
edited
Loading

I actually also think that we should at least test different python3 versions. It's easy to start using some py3.7 features that aren't there in 3.6 etc.

dvandyk added a commit that referenced this issue Sep 27, 2021
@dvandyk
[github] Verify that release and source code versions match
c175052 
Github: resolves #79
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dvandyk dvandyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dvandyk @klieret