Skip to content

Commit

Permalink
fix(application): update status causes sync release too fast (tkestac…
Browse files Browse the repository at this point in the history
…k#2153)

Co-authored-by: xdonggao <[email protected]>
  • Loading branch information
GaoXiaodong and xdonggao committed Nov 3, 2022
1 parent b989596 commit 13b64d0
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/application/controller/app/app_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,9 @@ func (c *Controller) syncAppFromRelease(ctx context.Context, cachedApp *cachedAp
}
return app, err
}
if app.Status.Phase == applicationv1.AppPhaseSucceeded && hasSynced(app) {
return app, nil
}
return c.updateStatus(ctx, app, &app.Status, newStatus)
}

Expand Down

0 comments on commit 13b64d0

Please sign in to comment.