Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image recommendations - Time-box new feature announcement #4860

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Image recommendations - Time-box new feature announcement #4860

merged 5 commits into from
Jun 25, 2024

Conversation

mfvarani
Copy link
Contributor

@mfvarani mfvarani commented May 24, 2024 •
edited
Loading

Phabricator: https://phabricator.wikimedia.org/T364397

Notes

  • PR adds an early return for the announcement of Image Recommendations for dates later than Oct 4, 2024. Added all logic in a single struct for easy cleanup after.
  • Also added my name to collaborators :) Thanks for the notice!

Test Steps

  1. Toggle this boolean for being able to get offered the image recommendations feature
  2. override hasPresentedFeatureAnnouncementModal to false to ignore UserDefaults and show the announcement modal.
  3. Check that modal still shows up as we are currently before the expiration date.

Screenshots/Videos
featureannouncement

@mfvarani mfvarani changed the title T364397 Image recommendations - Time-box new feature announcement May 24, 2024
@tonisevener tonisevener self-assigned this Jun 25, 2024
tonisevener
tonisevener approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@tonisevener tonisevener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for working on this.

@tonisevener tonisevener removed their assignment Jun 25, 2024
@tonisevener tonisevener merged commit 77cd25c into wikimedia:main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonisevener tonisevener tonisevener approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@mfvarani @tonisevener