Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variant issues in Notifications Center #4766

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Fix variant issues in Notifications Center #4766

merged 7 commits into from
Jun 26, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T357591

Notes

This is a bug I discovered and fixed while working on https://phabricator.wikimedia.org/T357370.

Test Steps

  1. Add a ZH Wiki language variant to app languages in Settings
  2. Go to Notifications Center Inbox. Confirm only one ZH language (correct variant) appears. Confirm filtering works correctly.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team February 28, 2024 16:19
@staykids staykids requested review from staykids and removed request for mazevedofs April 4, 2024 16:50
@staykids staykids assigned staykids and unassigned staykids Apr 4, 2024
@tonisevener tonisevener requested review from mazevedofs and removed request for staykids April 5, 2024 23:08
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@mazevedofs mazevedofs merged commit 0cf2d98 into main Jun 26, 2024
4 checks passed
@mazevedofs mazevedofs deleted the T357591 branch June 26, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants