Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old editor from project setup / scripts #4748

Merged
merged 7 commits into from
Jun 25, 2024
Merged

Remove old editor from project setup / scripts #4748

merged 7 commits into from
Jun 25, 2024

Conversation

tonisevener
Copy link
Collaborator

Phabricator:
https://phabricator.wikimedia.org/T357074

Notes

This PR removes CodeMirror references in our setup scripts, update languages script and removes the submodule. I got a bit sidetracked digging into why ClangFormat failed for me after the test steps, so I put a fix in for that at the end.

Test Steps

  1. Clone a fresh repo in a new directory.
  2. Run the ./scripts/setup script in the root directory.
  3. Confirm project runs.
  4. Try adding a poorly-formatted method to AppViewController.m.
  5. Try committing, confirm you see a "clang-format made formatting changes - verify them and re-commit.". Check git and confirm AppViewController.m was automatically formatted.
  6. Undo changes from previous steps. Run Update Languages utility. Confirm it completes, and you see git changes for the language and namespaces json files. Do not commit.

@tonisevener tonisevener requested review from a team and mazevedofs and removed request for a team February 9, 2024 23:47
Copy link
Collaborator

@mazevedofs mazevedofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great!

@mazevedofs mazevedofs merged commit 5572bdb into main Jun 25, 2024
4 checks passed
@mazevedofs mazevedofs deleted the T357074 branch June 25, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants