Propose fix some typos #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typos definitely, whitespace probably... Unfortunately, github is just a mirror, we develop and review over at https://gerrit.wikimedia.org Are you able to submit a changeset to gerrit? |
|
sure, I haven't used gerrit before? Do I fork or just clone directly? Should I just close this PR? I assume yes? |
|
You can just clone the repo from gerrit (or change the remote if you already have it from github). You can then push a patch for review |
wmfgerrit
pushed a commit
that referenced
this pull request
Jul 18, 2022
Third time's a charm Change-Id: Ifd94d8787a4224df02e40bdfe29e755cb0914f84
wmfgerrit
pushed a commit
that referenced
this pull request
Oct 11, 2022
Partitioning the ATS cache effectively wipes it so we need to proceed one server per cluster and DC at a time to avoid overwhelming the applayer. Affected servers: * cp1085 * cp1086 * cp2037 * cp2038 * cp3060 * cp3061 * cp4026 * cp4030 * cp5006 * cp5012 * cp6005 * cp6013 ATS needs to be restarted to apply the new cache partition schema Bug: T317748 Change-Id: I2e29c092d4b01850c0af60baebb824962fa2c6b4
wmfgerrit
pushed a commit
that referenced
this pull request
Jul 3, 2023
Bug: T329827 Change-Id: Idb5872e7471419b7a9ccf340c0ed4af40f78e550
wmfgerrit
pushed a commit
that referenced
this pull request
Jul 5, 2024
Why: Step #3 of the evaluation. Let's see what happens when 1 out of 5 servers doesn't prefetch the image Hosts: auto Bug: T366778 Change-Id: Ia4dda6c884d3146c9560eefaad32fbe9593ed843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK to remove some trailing white space and fix typos?