phpunit: Fix trivial dynamic property usages in tests

Dynamic property creation is deprecated in PHP 8.2 (E_DEPRECATED).
Migrate some trivial cases in tests to use explicitly declared fields
instead, and remove the unused lastLog field from
MediaWikiLoggerPHPUnitExtension.

Notably this does not yet address MediaWikiIntegrationTestCase using
dynamic properties to associate ephemeral data with DB connections used
for tests.

Bug: T314099
Change-Id: I55453c0d254012b69c6843c54cfa8345fa5744fa

tests/phpunit/MediaWikiLoggerPHPUnitExtension.php

@@ -44,7 +44,6 @@ class MediaWikiLoggerPHPUnitExtension implements
  * @inheritDoc
  */
  public function executeBeforeTest( string $test ): void {
- $this->lastTestLogs = null;
  $this->originalSpi = LoggerFactory::getProvider();
  $this->spi = new LogCapturingSpi( $this->originalSpi );
  LoggerFactory::registerProvider( $this->spi );

tests/phpunit/mocks/content/DummyContentForTesting.php

@@ -4,6 +4,8 @@ class DummyContentForTesting extends AbstractContent {
 
  public const MODEL_ID = "testing";
 
+ private $data;
+
  public function __construct( $data ) {
  parent::__construct( self::MODEL_ID );
 

tests/phpunit/suites/ParserIntegrationTest.php

@@ -50,7 +50,7 @@ public function __construct( $runner, $fileName, ParserTest $test, ParserTestMod
  [ "$mode" ],
  basename( $fileName ) . ': ' . $test->testName );
  $this->ptTest = $test;
- $this->ptTestMode = $mode;
+ $this->ptMode = $mode;
  $this->ptRunner = $runner;
  $this->skipMessage = $skipMessage;
  }
@@ -60,10 +60,10 @@ public function testParse() {
  $this->markTestSkipped( $this->skipMessage );
  }
  $this->ptRunner->getRecorder()->setTestCase( $this );
- $result = $this->ptRunner->runTest( $this->ptTest, $this->ptTestMode );
+ $result = $this->ptRunner->runTest( $this->ptTest, $this->ptMode );
  if ( $result === false ) {
  // Test intentionally skipped.
- $result = new ParserTestResult( $this->ptTest, $this->ptTestMode, "SKIP", "SKIP" );
+ $result = new ParserTestResult( $this->ptTest, $this->ptMode, "SKIP", "SKIP" );
  }
  $this->assertEquals( $result->expected, $result->actual );
  }

tests/phpunit/suites/ParserTestTopLevelSuite.php

@@ -15,6 +15,9 @@
 class ParserTestTopLevelSuite extends TestSuite {
  use SuiteEventsTrait;
 
+ /** @var PhpunitTestRecorder */
+ private $ptRecorder;
+
  /** @var ParserTestRunner */
  private $ptRunner;