jQuery.textSelection: Option values of undefined revert to defaults

Bug: T368102 Change-Id: Ie9bf594620344a4a451dae5bef91c0f2a6aca6da
wikimedia · Jun 21, 2024 · 4bcb5ac · 4bcb5ac
1 parent 337140f
commit 4bcb5ac
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/resources/src/jquery/jquery.textSelection.js b/resources/src/jquery/jquery.textSelection.js
@@ -428,6 +428,13 @@
  $.fn.textSelection = function ( command, commandOptions ) {
  var alternateFn = $( this ).data( 'jquery.textSelection' );
 
+ // Prevent values of `undefined` overwriting defaults (T368102)
+ for ( var key in commandOptions ) {
+ if ( commandOptions[ key ] === undefined ) {
+ delete commandOptions[ key ];
+ }
+ }
+
  // Apply defaults
  switch ( command ) {
  // case 'getContents': // no params