Test travis with different hhvm versions #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It fails with segfault with the latest version. See facebook/hhvm#7779
|
Didn't work |
|
We suggest running HHVM on docker in travis. If you are interested I should be able to point you at an example project. The newest versions of HHVM don't support Ubuntu trusty, and travis has yet to add support for Ubuntu Xenial. We get around this by using docker. |
|
@mofarrell That'd be great. |
|
This leaves out running with PHP, but this project includes |
wmfgerrit
pushed a commit
that referenced
this pull request
Mar 4, 2021
All changes taken, with very slight changes, from previous cherry-picks by Tobias Andersson, while originally authored by: (3) Tobias Andersson <[email protected]> (1) rosalie <[email protected]> (1) Marius Hoch <[email protected]> This is the 1st commit message: FP: Refactor test dirs / testcase usage Bug: T255788 Change-Id: Ifa09c21a17f7d906d4adbf2b0677e82d24380127 (cherry picked from commit 206897e) This is the commit message #2: FP: View details of a deleted property used in a statement Make PT:wikibase-property use the NonExistingEntityIdHtmlBrokenLinkFormatter for non existing PropertyIds Bug: T255417 Change-Id: Ifab1be93e5269437afddf3e3ab44f7bedc5bd8a0 (cherry picked from commit 1c9e410) This is the commit message #3: FP: Handle FP exceptions in HtmlPageLinkRendererEndHookHandler This will fallback to using the plain entity id as title and link text, and it will link via Special:EntityData (as we can't lookup namespaces). Bug: T257217 Change-Id: If7e8118678737b6dda3e8735a58830b41a84d3ec (cherry picked from commit e7736ae) This is the commit message #4: FP: Add section on configuring entitysources Using a different source wiki entity sources cannot be automatically configured and we need to add a section on how this can be done manually. Bug: T257908 Change-Id: I3458a8aa2c482648288114a453188f12b2b18d44 (cherry picked from commit 6801836) This is the commit message #5: FP: Initialize entitysource defaults When no entitysources are configured and federatedproperties are enabled we are able to configure the entitysources directly instead of leaving this to the user. Bug: T257907 Change-Id: I3ab853558c91c91897baa57ad1a28511693f5523 (cherry picked from commit c8a2ec8)
wmfgerrit
pushed a commit
that referenced
this pull request
Mar 4, 2021
All changes taken, with very slight changes, from previous cherry-picks by Tobias Andersson, while originally authored by: (3) sihe <[email protected]> (1) rosalie <[email protected]> (1) Tobias Andersson <[email protected]> This is the 1st commit message: FP: Add WDQS to the test system's ansible config This adds Wikidata Query Service to the Federated Properties test system by adding four containers (wdqs-frontend, wdqs, wdqs-updater and wdqs-proxy) to the docker-compose.yml file. Required EntitySource configurations are added to LocalSettings.php and a previously missing .htaccess file now enables redirects for the /entity/Qxx URI scheme. Bug: T257213 Change-Id: I7e5ac4a66052547252fd64b0d0d186c31db387ef (cherry picked from commit 90116d3) This is the commit message #2: FP: Maintenance script for test instance #1 We need to prepare one of the test instances created with a sample set of items to be used for testing federated properties. Bug: T255648 Change-Id: I8fd206134dc66ac68047bf64c324db8ef2390c11 (cherry picked from commit 1c5c7ee) This is the commit message #3: FP: Add eu-invasive-species to ansible test setup This adds configuration for the user testing system 'Invasive Species' to the ansible inventory and adds a few necessary fixes to the setup process. Bug: T256457 Change-Id: I926f7c6653fbff4454073fef490fc92ae2da407d (cherry picked from commit 2424c0d) This is the commit message #4: FP: Add sparql queries to documentation Bug: T246615 Change-Id: I1a16f69b93adeea9fda3f522e878a15459e3cca0 (cherry picked from commit ac254b9) This is the commit message #5: FP: Add opennext to ansible test setup This adds configuration for the user testing system 'OPEN!NEXT' to the ansible inventory. Bug: T256457 Change-Id: If5eb093ed8ac24556efcbce4d2740ffa6ec3d7b6 (cherry picked from commit 5e92960)
wmfgerrit
pushed a commit
that referenced
this pull request
Mar 4, 2021
All changes taken, with very slight changes, from previous cherry-picks by Tobias Andersson, while originally authored by: (3) addshore <[email protected]> (2) Tobias Andersson <[email protected]> This is the 1st commit message: FP: Add notification for leaving site Bug: T257910 Change-Id: I81eec5c361ffb425ec64bf88a2de840449c769ed (cherry picked from commit 5f1cd26) This is the commit message #2: FP: use the local ns id for properties in entitysources With the way our existing services are currently wired up etc this ns ID needs to match the local location that properties would be if they were local, so that links etc get created with the correct prefix. If this is set to the namespace ID of the remote wiki, the links end up wrong, for example Item:P31. A concrete example would be: My local dev install, NS120 = items, NS 122 = properties Wikidata, NS0 = items, NS 120 = properties If my entity source for wikidata on my local install says that properties are in NS 120, then links will be created locally for NS 120, which is infact where items are locally. This results in "Item:P31" instead of ":P31" This fact is now also documented in the fed props docs. This was noticed while investigating T258564 (the linked bug) but does not solve that task, but was in the way of solving it. Bug: T258564 Change-Id: Id5e6bd7761aeaa49fa4c749aa143ca7bd3e848ab (cherry picked from commit f7cff4e) This is the commit message #3: FP: Update ansible README for demo instances Bug: T256457 Bug: T259782 Change-Id: If54051ae64d69544e508c5282026ac6cf3d92923 (cherry picked from commit 1849cd1) This is the commit message #4: FP: ansible, also run composer update This was needed in order to make the playbook run on eu-invasive-species-federated-properties.wmflabs.org as mediawiki kept complaining that the packages had not been udpated. Composer update should probably be done as part of a cron too? Bug: T259782 Change-Id: If38d75f4d8b069af5cde7ed17c5aa54fe0abf634 (cherry picked from commit 50e5624) This is the commit message #5: FP: Persist leaving site notice Add the checkbox, store in cookie for anon user and user preferences for logged in users. Bug: T258039 Bug: T258040 Change-Id: I39afd7005636b7d3562c6bae81de460794849b2f (cherry picked from commit 1835a28)
wmfgerrit
pushed a commit
that referenced
this pull request
Mar 4, 2021
All changes taken, with very slight changes, from previous cherry-picks by Tobias Andersson, while originally authored by: (3) Tobias Andersson <[email protected]> (1) addshore <[email protected]> (1) sihe <[email protected]> This is the 1st commit message: FP: Use correct interwiki for fed props entity source In order for the formatting of summaries to correctly work the interwiki used in the entitysource must be defined as it is checked. wd was used but is not defined by default, wikidata however is. This change also slightly alters the fed props docs to reflect the fact that the interwiki does need to be correct, and also makes the example look more realistic. The LinkRenderedEndHook was once again touched as apparently the hook can also parse links such as "wikidata:Special:EntityPage/Q123" as being in the "main namespace" with ns id 0 for the local wiki, even though to us humans if is obviously in the -1 special NS on the remote wiki. As far as I can tell the exact case that I touching here is already tested. So I am a bit confused currently as to why the tests did not fail. Bug: T258564 Change-Id: I5d7199ceb26d2b449e0b9b70cc43219200442076 (cherry picked from commit 92bcea7) This is the commit message #2: FP: Update interwiki configuration for test instances Change-Id: Iecbdd615cfd513ab9c47c13e6645691dc470034e (cherry picked from commit 0a8c822) This is the commit message #3: FP: Update readme to use iw_local set to 0 Looking at the populated interwiki links they all use 0 instead of 1. We should probably use the same. Change-Id: Ie5ade66fa43f25d412cf8a9a61a2f379f9339f9d (cherry picked from commit 9a8a650) This is the commit message #4: FP: Add documentation on caching Bug: T258681 Change-Id: I9e81a23940d1024a92069450638415589fa539b1 (cherry picked from commit ad3cdc2) This is the commit message #5: FP: Use tmpfs for test system's WDQS /tmp folder The WDQS docker container creates a new temporary jetty folder in /tmp every time it is (re-)started. In order to prevent the file system from filling up over time, the /tmp folder is now mounted as tmpfs via docker-compose.yml. This way it is kept in memory and will be removed every time the container stops. Bug: T260348 Change-Id: I6a1d94eb1f4912332da9fc076d85cf21bab343c0 (cherry picked from commit 4640506)
wmfgerrit
pushed a commit
that referenced
this pull request
Mar 4, 2021
All changes taken, with very slight changes, from previous cherry-picks by Tobias Andersson, while originally authored by: (4) Tobias Andersson <[email protected]> (1) addshore <[email protected]> This is the 1st commit message: FP: Show diff pages even when FP has connection issues This catches exceptions in a couple of different places and provides some less explosive defaults. 1) When rendering the actual diff the label is fetched. Now this just displays the property ID instaed (with no link) 2) Diff pages normally display the page below the diff output. This is now blank, as this needs ParserOutput which we currently do not render when there is no connection. Bug: T258173 Change-Id: Iac3fca8d2da4115ff43a711c38c0549141665f76 (cherry picked from commit 65622b1) This is the commit message #2: FP: Prepare api for invalidating editing properties - add error message - make WikibaseRepo::inFederatedPropertyMode public - make EntitySavingHelper::getEntityIdFromParams public - add trait for validating Bug: T258558 Change-Id: If302c489c626bb8a8285b75f2db720e320ca6c45 (cherry picked from commit 0f09279) This is the commit message #3: FP: Modify/Edit-Entity should not allow altering properties Bug: T258558 Change-Id: Ic39ab158617a8cb92cb1f09ecbc09e1477ae2fcb (cherry picked from commit 261ef2f) This is the commit message #4: FP: Create claim should not allow altering properties Bug: T258558 Change-Id: Ia1e2a13bb157588a67ea627b58d973f5ffe699d6 (cherry picked from commit f3abc9b) This is the commit message #5: FP: RemoveQualifiers should not allow altering properties Bug: T258558 Change-Id: I80e07cb7e83497cfaee21af61f11281e48fb988f (cherry picked from commit 31b1905)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fails with segfault with the latest version. See facebook/hhvm#7779