jquery.i18n.fallbacks.js: Add sr-cyrl as fallback for sr #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdforrester
approved these changes
Aug 16, 2022
|
Leaving to the Language Engineering team to decide. |
|
I'm going to be bold here, too: since this is merged into core, it should live here too. Language team can revert (here and in core) if there's an issue, but IMO fallbacks here are just a matter of standards-compliance. |
wmfgerrit
pushed a commit
to wikimedia/mediawiki
that referenced
this pull request
Aug 31, 2022
Fix the following failures: * intersection-observer: Partial undo of 803b873, local docs-only change to vendor files. * jquery.i18n: - jquery.i18n.messagestore.js: Partial undo 7a4df9b (I83bbbb150), comment change to vendor file. - jquery.i18n.fallbacks.js: This was changed locally in 6839b85 (I666fbdea8) in July and upstreamed by @reedy in wikimedia/jquery.i18n#243. Since there is only one other patch upstream, a cosmetic one, since 1.0.7, I've changed it to an unreleased commit hash upstream so that at least the registration roundtrips cleanly. We can update to the proper release when we're ready for that (there's something to figure out w.r.t plural rule parsing). * moment: Rename en-sg.js to match package. * jquery.cookie: Recognise this as the fork that it is. Comment-out for now to exclude it from validation since it can't pass. We should probably just move this to src/ and embed it within mw.cookie or something. Bug: T203694 Change-Id: Ie705070c695e5e4ab95b51ceb434a0eadfa0f733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming https://gerrit.wikimedia.org/r/c/mediawiki/core/+/467770/34/resources/lib/jquery.i18n/src/jquery.i18n.fallbacks.js
https://phabricator.wikimedia.org/T117845